Skip to content

tests: fixup interfaces account control - #17032

Merged
maykathm merged 4 commits into
canonical:masterfrom
maykathm:fixup-interfaces-account-control
May 8, 2026
Merged

tests: fixup interfaces account control#17032
maykathm merged 4 commits into
canonical:masterfrom
maykathm:fixup-interfaces-account-control

Conversation

@maykathm

@maykathm maykathm commented May 7, 2026

Copy link
Copy Markdown
Contributor

Follow-up from #16983

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.13%. Comparing base (972b56f) to head (7213a9a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17032      +/-   ##
==========================================
+ Coverage   79.07%   79.13%   +0.06%     
==========================================
  Files        1375     1364      -11     
  Lines      191265   191108     -157     
  Branches     2465     2465              
==========================================
- Hits       151236   151235       -1     
+ Misses      30925    30768     -157     
- Partials     9104     9105       +1     
Flag Coverage Δ
unittests 79.13% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Thu May 7 14:53:42 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/25499485597

Failures:

Skipped tests from snapd-testing-skip

If you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)

  • garden:ubuntu-25.10-64:tests/main/apparmor-prompting-support

@maykathm
maykathm force-pushed the fixup-interfaces-account-control branch from 83d9233 to df4f55e Compare May 7, 2026 13:07
@maykathm
maykathm force-pushed the fixup-interfaces-account-control branch from df4f55e to 7213a9a Compare May 7, 2026 13:40
can handle the user accounts properly.

systems: [ubuntu-core-16-64, ubuntu-core-18-64, ubuntu-core-20-64, ubuntu-core-22-64, ubuntu-core-24-64, ubuntu-core-26-64]
systems: [ubuntu-core-*]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we expect this test to fail whenever a new UC system is added and then add the local snap files for that UC version?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I think that's probably best anyway. That way we know we need to update this test and it doesn't fall behind as it did.

@Rnfudge02 Rnfudge02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maykathm
maykathm merged commit ddad2c9 into canonical:master May 8, 2026
115 checks passed
@maykathm
maykathm deleted the fixup-interfaces-account-control branch May 8, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants